Fixed cleanCoords to remove points with appropriate tenacity #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er with lines that retrace or pass back through their origin. Note depends on PR Turfjs#2751 to be merged first as part of the problem was booleanPointOnLine misbehaving.
…was one of the points that should be cleaned.
…part of clean operation.
…gment was causing errors - started checking number of points before doing other tests. Replaced our own booleanEquals with external geojsonEquality. booleanEquals uses cleanCoords, which we're using to check ... cleanCoords. Fixed a couple of linting issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases cleanCoords was being too aggressive when it removed points.
In other cases, if the start point of a line was a valid point to remove, it wasn't being discarded.
Resolves #2305
Resolves #2406
Resolves #2740
Please provide the following when creating a PR:
contributorsfield ofpackage.json- you've earned it! 👏