Skip to content

Conversation

PPPDUD
Copy link
Contributor

@PPPDUD PPPDUD commented Sep 18, 2025

I've noticed that a lot of developers writing new extensions for TurboWarp are not paying much attention to the translatability of their work, and I don't blame them. Nowhere in the documentation or contribution guidelines do we mention things like Scratch.translate(), and so many extensions take much longer to refine before they get accepted.

I have written a rough draft for improved guidelines that will hopefully make this situation much more manageable. A lot of help is needed; feel free to improve it!

@PPPDUD PPPDUD self-assigned this Sep 18, 2025
@PPPDUD PPPDUD added documentation Improvements or additions to documentation help wanted Extra attention is needed pr: other Pull requests that neither add new extensions or change existing ones labels Sep 18, 2025
@Brackets-Coder
Copy link
Contributor

Okay
I'm going to wait for Mr. Weber's opinion on this.

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Sep 18, 2025

@Brackets-Coder Sorry for requesting another review, I didn't know what that button did.

Copy link
Contributor

@Brackets-Coder Brackets-Coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but I'm still going to wait...

@PPPDUD PPPDUD requested a review from a team September 19, 2025 14:16
@PPPDUD
Copy link
Contributor Author

PPPDUD commented Sep 19, 2025

If you're coming here because I requested a review from the whole team, I apologize. I figured that this would be relevant to all of us. Please add a thumbs-down emoji in the little emoji reaction button if that annoyed you.

@Brackets-Coder
Copy link
Contributor

It's relevant to all of us, but I don't think you should request a review from the whole team... personally, I think something like this is better for Mr. Weber to review.

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Sep 19, 2025

It's relevant to all of us, but I don't think you should request a review from the whole team... personally, I think something like this is better for Mr. Weber to review.

Should I revoke the request for review?

@SharkPool-SP
Copy link
Collaborator

You should include not using translation.setup or whatever it's called.

Also include how to use that function

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Sep 19, 2025

You should include not using translation.setup or whatever it's called.

Also include how to use that function

I don't know nearly enough about this stuff because it's poorly documented (that's why this PR is still a draft). Feel free to request changes if you have a more in-depth explanation!

@SharkPool-SP
Copy link
Collaborator

You should include not using translation.setup or whatever it's called.

Also include how to use that function

I don't know nearly enough about this stuff because it's poorly documented (that's why this PR is still a draft). Feel free to request changes if you have a more in-depth explanation!

For the "how to use part", just say smt like:
Format it like this:
Scratch.translate("text")

Then say do not use Scratch.translate.setup or whatever it is

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Sep 19, 2025

You should include not using translation.setup or whatever it's called.

Also include how to use that function

I don't know nearly enough about this stuff because it's poorly documented (that's why this PR is still a draft). Feel free to request changes if you have a more in-depth explanation!

For the "how to use part", just say smt like: Format it like this: Scratch.translate("text")

Then say do not use Scratch.translate.setup or whatever it is

I really think that there should be a seperate page in the documentation about this, which I can then link to.

@SharkPool-SP
Copy link
Collaborator

Not rlly sure how important that is given that it's 2 lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed pr: other Pull requests that neither add new extensions or change existing ones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants