Made a Geolocation extension #1943

samuellouf · 2025-02-19T09:35:04Z

Hello, folks!
I made a Geolocation extension.
Enjoy!

samuellouf · 2025-02-20T14:50:46Z

This is pretty simple, I will give it a review later today if I don't forget

Thanks!

samuellouf · 2025-02-20T15:52:42Z

~~Okay, I'm just gonna add Geocoding Blocks.~~ I'm giving up on that idea. I will probably do a separate "Geocoding" extension.

samuellouf · 2025-02-21T08:21:44Z

Here ! It's finally done!

Brackets-Coder

Looks fine to me! All protocols are being followed and I don't see any reason why this can't be merged now.

Brackets-Coder · 2025-05-05T16:05:53Z

extensions/SamuelLouf/Geolocation.js

+  "use strict";
+
+  function getGeolocation(
+    options = { enableHighAccuracy: true, timeout: 5000, maximumAge: 0 }


I'm not familiar with geolocation apis but will the timeout affect anything?

Not really : timeout is the limit you give to geolocate the device.
In this case, the getGeolocation function gives the browser 5000ms (or 5s) tops to geolocate the device.
It's the setTimeout function that slows down/stops the code. See on mdn web docs.

Brackets-Coder · 2025-05-05T16:07:32Z

extensions/SamuelLouf/Geolocation.js

+    async getCurrent(args) {
+      if (!(await this.isAllowed())) return "";
+      var coordinates = await getGeolocation();
+      if (coordinates.success == true) {
+        return coordinates[args.WHAT];
+      } else {
+        return "";
+      }
+    }
+
+    async isAllowed() {
+      return await Scratch.canGeolocate();
+    }


@yuri-kiss are we allowed to make block functions themselves asynchronous or should we put asynchronous functions inside them?

PPPDUD

I can't find any blocks to actually get my location, which is a pretty necessary feature for a geolocation extension.

Brackets-Coder · 2025-09-15T16:56:57Z

I can't find any blocks to actually get my location, which is a pretty necessary feature for a geolocation extension.

huh didn't notice that, maybe we're missing something?

CST1229 · 2025-09-16T12:48:52Z

I can't find any blocks to actually get my location, which is a pretty necessary feature for a geolocation extension.

it's an error with the extension. the block has the wrong menu so it points to one that doesn't exist (it should be coordinates)

Brackets-Coder · 2025-09-16T13:02:25Z

I can't find any blocks to actually get my location, which is a pretty necessary feature for a geolocation extension.

it's an error with the extension. the block has the wrong menu so it points to one that doesn't exist (it should be coordinates)

Thanks, I didn't notice

samuellouf · 2025-09-17T09:28:02Z

I can't find any blocks to actually get my location, which is a pretty necessary feature for a geolocation extension.

it's an error with the extension. the block has the wrong menu so it points to one that doesn't exist (it should be coordinates)

You are right.

samuellouf · 2025-09-17T09:28:29Z

Dunno how I let that slip.

samuellouf · 2025-09-17T09:30:13Z

Fixed it!!

Brackets-Coder · 2025-09-17T12:04:03Z

Fixed it!!

I'll check when I can

PPPDUD

I am quite impressed by this extension. All of the relevant blocks are there, and all checks have passed. @samuellouf You have my blessing.

Brackets-Coder

Get longitude and latitude doesn't seem to work for me in Safari (the block says it's supported and it's not an API limitation), and in Firefox longitude is negative where for me it should be positive according to my Maps app.

Once these issues are fixed I think we'll be good to go

- Changed the default timeout - Fixed the `getCurrent` timeout (it wasn't taken into account until this fix)

samuellouf · 2025-09-19T12:55:01Z

I just made a few changes :

Changed the default timeout (bc I realised 5 seconds weren't enough)
Fixed the getCurrent function (the timeout and the accuracy weren't taken into account until this fix)

samuellouf · 2025-09-19T13:02:49Z

Get longitude and latitude doesn't seem to work for me in Safari (the block says it's supported and it's not an API limitation), and in Firefox longitude is negative where for me it should be positive according to my Maps app.

Perhaps there's something wrong with your computer or your phone. (No offense)
It works for me on both Google Chrome and Firefox on Windows 10, 11, and Linux Mint.

samuellouf · 2025-09-19T13:08:00Z

@PPPDUD, could you check if the position the extension returns is valid?

Brackets-Coder

Still doesn't seem to work in Safari

Brackets-Coder · 2025-09-19T13:10:44Z

Get longitude and latitude doesn't seem to work for me in Safari (the block says it's supported and it's not an API limitation), and in Firefox longitude is negative where for me it should be positive according to my Maps app.

Perhaps there's something wrong with your computer or your phone. (No offense) It works for me on both Google Chrome and Firefox on Windows 10, 11, and Linux Mint.

It's not the computer, I'm on a modern Mac with the latest software version. It works in Firefox, not Safari- it's not a browser limitation because the extension says I support geolocation and Apple's MapJS kit wouldn't work without geolocation capabilities, so something about the get location reporter doesn't work in Safari.

Also, the longitude is still negative, where according to my maps app, it should be positive.

samuellouf · 2025-09-19T13:18:16Z

Get longitude and latitude doesn't seem to work for me in Safari (the block says it's supported and it's not an API limitation), and in Firefox longitude is negative where for me it should be positive according to my Maps app.

Perhaps there's something wrong with your computer or your phone. (No offense) It works for me on both Google Chrome and Firefox on Windows 10, 11, and Linux Mint.

It's not the computer, I'm on a modern Mac with the latest software version. It works in Firefox, not Safari- it's not a browser limitation because the extension says I support geolocation and Apple's MapJS kit wouldn't work without geolocation capabilities, so something about the get location reporter doesn't work in Safari.

That's interesting. I don't get why it isn't working. It should work.
Is the longitude still negative?

…into Geolocation

samuellouf · 2025-09-19T13:25:57Z

Should I add a "when user moves" block? (It would be a hat, ofc)
It would be paired with latitude, longitude, accuracy blocks.
It seems to be easily doable.

Brackets-Coder · 2025-09-19T13:28:20Z

Get longitude and latitude doesn't seem to work for me in Safari (the block says it's supported and it's not an API limitation), and in Firefox longitude is negative where for me it should be positive according to my Maps app.

Perhaps there's something wrong with your computer or your phone. (No offense) It works for me on both Google Chrome and Firefox on Windows 10, 11, and Linux Mint.

It's not the computer, I'm on a modern Mac with the latest software version. It works in Firefox, not Safari- it's not a browser limitation because the extension says I support geolocation and Apple's MapJS kit wouldn't work without geolocation capabilities, so something about the get location reporter doesn't work in Safari.

That's interesting. I don't get why it isn't working. It should work. Is the longitude still negative?

Yes, but I'm not 180º on the other side of the world. A theory, I updated to the latest major macOS Tahoe release recently and it's a .0 version. I've discovered a few UI inconsistencies after the redesign so there may be potential functionality issues in the latest version, but it's very unlikely.

Brackets-Coder · 2025-09-19T13:28:44Z

Should I add a "when user moves" block? (It would be a hat, ofc) It would be paired with latitude, longitude, accuracy blocks. It seems to be easily doable.

Depends on whether users would use it and how performant it would be

Brackets-Coder · 2025-09-19T13:41:26Z

Hmm... it seems like I have location services disabled in settings and Firefox is attempting to override it, so it may be faulty. I'll test it later when I have time

PPPDUD · 2025-09-19T14:12:59Z

Should I add a "when user moves" block? (It would be a hat, ofc) It would be paired with latitude, longitude, accuracy blocks. It seems to be easily doable.

@samuellouf That is genius, please add that! You might want to add a way to enable or disable that block though, since it's probably gonna eat up time pretty easily (see @Brackets-Coder's comment).

Added "onUserMove"

samuellouf · 2025-09-20T12:51:17Z

Should I add a "when user moves" block? (It would be a hat, ofc) It would be paired with latitude, longitude, accuracy blocks. It seems to be easily doable.

@samuellouf That is genius, please add that! You might want to add a way to enable or disable that block though, since it's probably gonna eat up time pretty easily (see @Brackets-Coder's comment).

Done !

I added some code that sends the event, gets the threads to which the event was sent, and returns the value in the get [WHAT] block.

    async getCurrent(args, util) {
      if (!(await this.isAllowed())) return "";
      var coordinates =
        util.thread._coordinates || (await getGeolocation(this.options));
        // read the coordinates in the thread if present OR get the current coordinates
      if (coordinates.success == true) {
        return coordinates[args.WHAT];
      } else {
        return "";
      }
    }

    async changePositionWatching(args) {
...
        this.watcherID = navigator.geolocation.watchPosition(
          (pos) => {
            var threads = Scratch.vm.runtime.startHats(
              "samuelloufgeolocation_onUserMove"
            ); // Trigger the hat
            for (var thread of threads) { // for each thread
              var coords = pos.toJSON().coords; // Turn the coordinates into JSON
              coords.success = true; // Add success
              // @ts-ignore
              thread._coordinates = coords; // Add the coordinates to the thread
            }
          },
          () => {},
          this.options
        );
...
    }

Fixed Geolocation extension

32ac69e

github-actions bot added the pr: new extension Pull requests that add a new extension label Feb 19, 2025

This comment was marked as abuse.

Sign in to view

Merge branch 'TurboWarp:master' into Geolocation

9ff402c

samuellouf and others added 2 commits February 20, 2025 23:49

Merge branch 'TurboWarp:master' into Geolocation

c727d7b

Added Translations to Menus

2b7df20

samuellouf added 2 commits February 21, 2025 13:41

Merge branch 'TurboWarp:master' into Geolocation

8ce4d67

Merge branch 'TurboWarp:master' into Geolocation

ab55fe4

Brackets-Coder reviewed May 5, 2025

View reviewed changes

Brackets-Coder mentioned this pull request Sep 13, 2025

New Extension: Location #2179

Closed

PPPDUD requested a review from CubesterYT September 15, 2025 16:41

PPPDUD requested changes Sep 15, 2025

View reviewed changes

samuellouf added 2 commits September 17, 2025 11:29

Update Geolocation.js

a7af317

Merge branch 'TurboWarp:master' into Geolocation

3d966ba

samuellouf requested a review from PPPDUD September 17, 2025 09:34

PPPDUD approved these changes Sep 17, 2025

View reviewed changes

Brackets-Coder requested changes Sep 17, 2025

View reviewed changes

Made a few important changes

43b396e

- Changed the default timeout - Fixed the `getCurrent` timeout (it wasn't taken into account until this fix)

Merge branch 'master' into Geolocation

a7f9eef

samuellouf requested a review from Brackets-Coder September 19, 2025 13:05

Brackets-Coder requested changes Sep 19, 2025

View reviewed changes

samuellouf added 2 commits September 19, 2025 15:18

Formated it

e09c28a

Merge branch 'Geolocation' of https://github.com/samuellouf/extensions …

f78876e

…into Geolocation

PPPDUD self-requested a review September 19, 2025 14:10

samuellouf added 2 commits September 20, 2025 14:15

Made various changes

4511d9b

Added "onUserMove"

Formated the extension

0bd1ef4

Made a Geolocation extension #1943

Are you sure you want to change the base?

Made a Geolocation extension #1943

Conversation

samuellouf commented Feb 19, 2025

Uh oh!

This comment was marked as abuse.

samuellouf commented Feb 20, 2025

Uh oh!

samuellouf commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samuellouf commented Feb 21, 2025

Uh oh!

Brackets-Coder left a comment

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder May 5, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

samuellouf May 9, 2025

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder May 5, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

PPPDUD left a comment

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder commented Sep 15, 2025

Uh oh!

CST1229 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Brackets-Coder commented Sep 16, 2025

Uh oh!

samuellouf commented Sep 17, 2025

Uh oh!

samuellouf commented Sep 17, 2025

Uh oh!

samuellouf commented Sep 17, 2025

Uh oh!

Brackets-Coder commented Sep 17, 2025

Uh oh!

PPPDUD left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samuellouf commented Sep 19, 2025

Uh oh!

samuellouf commented Sep 19, 2025

Uh oh!

samuellouf commented Sep 19, 2025

Uh oh!

Brackets-Coder left a comment

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder commented Sep 19, 2025

Uh oh!

samuellouf commented Sep 19, 2025

Uh oh!

samuellouf commented Sep 19, 2025

Uh oh!

Brackets-Coder commented Sep 19, 2025

Uh oh!

Brackets-Coder commented Sep 19, 2025

Uh oh!

Brackets-Coder commented Sep 19, 2025

Uh oh!

PPPDUD commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samuellouf commented Feb 20, 2025 •

edited

Loading

CST1229 commented Sep 16, 2025 •

edited

Loading

PPPDUD left a comment •

edited

Loading

Brackets-Coder left a comment •

edited

Loading

PPPDUD commented Sep 19, 2025 •

edited

Loading