-
Notifications
You must be signed in to change notification settings - Fork 286
New Extension: Particle Engine #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Peak!! |
Two questions I have:
|
yes |
WOW! a new particle engine with no clones! that's great for performance and now overflow your projects with clones! (even if i use clones, a lot) |
Additionally, blocks in the editor are all SVGs, which means you can't color them with any html property. You have do what I do and make SVG gradients or patterns. |
well, i just function add2Body() {
var svg = document.createElement("div");
svg.innerHTML = \`<svg><defs>
<linearGradient x1="100" y1="0" x2="100" y2="200" id="SPpartEngine-GRAD1" gradientUnits="userSpaceOnUse"><stop offset="0" stop-color="#0090ff"></stop><stop offset="50%" stop-color="#0000ff"></stop></linearGradient>
</defs></svg>`;
document.body.appendChild(svg);
}
if (Scratch.gui) Scratch.gui.getBlockly().then((SB) => {
add2Body();
if (!SB?.SPgradients?.patched) { // Gradient Patch by 0znzw & SharkPool
SB.SPgradients = {gradientUrls: {}, patched: false};
const BSP = SB.BlockSvg.prototype, BSPR = BSP.render;
BSP.render = function(...args) {
const res = BSPR.apply(this, args);
let category;
if (this?.svgPath_ && this?.category_ && (category = this.type.slice(0, this.type.indexOf("_"))) && SB.SPgradients.gradientUrls[category]) {
const urls = SB.SPgradients.gradientUrls[category];
if (urls) this.svgPath_.setAttribute("fill", urls[0]);
}
return res;
}
SB.SPgradients.patched = true;
}
SB.SPgradients.gradientUrls["SPpartEngine"] = ["url(#SPpartEngine-GRAD1)"];
}); |
I've already looked at the code, but I don't intend to use it for my extensions. Thank you anyway though. |
Interesting. I was just curious as to if we could change the scratch-gui repo to add some sort of functionality for gradients and CSS colors in the block color APIs, but I guess not - It didn't occur to me that the SVGs can't use CSS gradients. Maybe we could use this patch though, and manually inject the colors into the patch? IDK, it's just an idea. Probably won't be done though. What might be more possible is expanding the customizable block colors addon to allow for gradients. |
Theres now an interpolation option! :) |
!format |
!format |
Basically just remove the text from the banner then I guess we're good to merge this peak |
I think documentation can be saved for another time, the blocks are in order of usability. So it should be easy to pickup. It works closely to the geometry dash particle engine as well. We can always go back and add it if need be |
In my testing it didn't take me long to figure out but I couldn't get engines working on sprites, only the stage? Maybe I was doing something wrong |
Wdym. The engines don't follow sprites, they're just attached to them |
No, I meant I for some reason couldn't get them working when attached to a sprite, I rushed through it so I must've done something wrong |
add punctuation to end of description comment
Maybe you didn't make an emitter for that engine? |
Oops I got it working sorry |
Yeah just change the banner and we should be good to go |
Is that a gradient for the block colors? Looks really nice. |
Yes |
I didn't know that block colors could use gradients! |
They can't by default, it's an SVG patch. |
I see. |
alright fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, everything looks good!
I'm going to have to pass for tonight, but I might be willing to review tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- when i change the VM fps to 60, i would expect the particles to not move twice as fast. there does seem to be delta time logic at least in some places. is it not being used? ✅
- when i have an emitter going and i resize the stage, i would expect the particle canvas to resize too and at least appear in the right spot after the resize (as is, stage emitter is very offset to the right after resizing 480x360 to 640x360) ✅
- the dropdowns in the flyout only update after exiting the editor and going back in; newly creates sprites will not show up ✅
- uploading one webgl context to another context seems to be slow. create like 10 particle engines, even with almost nothing going on, it gets really slow: https://share.firefox.dev/4gty2bI ✅ [Not Fixing, other gallery extensions use this method]
- chrome limits max webgl contexts per tab to something like 16, so by the time someone makes their 16th particle context, the context used by the vm will be lost until a full refresh ✅
- even if unused engines are removed with the block, it's not guaranteed that chrome will garbage collect them and release the webgl slot right away (make a "create engine for x / remove engine for x" script and duplicate it on top of itself 20 times to see example)
- blend modes are seemingly affected by same problems as in #2142 (set particle blend mode to subtract in light mode for an example) ✅
- the particles are highly pixelated in fullscreen and on high dpi displays outside of fullscreen ✅ [Not Fixing]
} | ||
} | ||
|
||
if (Scratch.gui) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think if you want gradients i think you should make a documented pr with a couple test cases so all the extensions get it. as-is this also breaks colored context menus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colored context menus is bug with the addon, even if you make this a actual thing, the addon would still be broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and Id rather not wait 6+ months just to get a PR merged from you
Next time I'll review more thoroughly... |
!format |
Create Powerful Particle Engines with NO Clones
Screen.Recording.2024-10-15.at.12.31.42.AM.mov
wow.particles.mp4