Skip to content

Fix missing bottom and right borders in table cells (Issue #160) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolasiscoding wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix missing bottom and right borders in table cells (Issue #160) #162

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b3b300
Fix missing bottom and right borders in table cells (Issue #160)
nicolasiscoding Dec 31, 2025
1388241
Add exact test case from Issue #160 bug report
nicolasiscoding Dec 31, 2025
770e844
Update tests/table-cell-borders.test.js
nicolasiscoding Jan 16, 2026
66fa61f
fix: respect border-style: hidden and none in table cells
nicolasiscoding Jan 20, 2026
e0b0df3
test: port comprehensive table border tests from example-node.js
nicolasiscoding Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 24 additions & 39 deletions src/helpers/xml-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,10 +1763,10 @@ const buildTableCellBorders = (tableCellBorder) => {

const { colors, strokes, ...borders } = tableCellBorder;
Object.keys(borders).forEach((border) => {
if (tableCellBorder[border]) {
if (borders[border]) {
const borderFragment = buildBorder(
border,
tableCellBorder[border],
borders[border],
0,
colors[border],
strokes[border]
Expand Down Expand Up @@ -2569,43 +2569,28 @@ const buildTableCell = async (
const columnIndexEquivalentFirst = columnIndexEquivalent.indexOf('first');
const columnIndexEquivalentLast = columnIndexEquivalent.indexOf('last');

// if table cell styles will be given, then below 4 are overridden
if (rowIndexEquivalentFirst !== -1) {
// it means that the cell is in first row
// we set the top border of cells to table top border
modifiedAttributes.tableCellBorder.strokes.top = modifiedAttributes.tableBorder.strokes.top;
modifiedAttributes.tableCellBorder.colors.top = modifiedAttributes.tableBorder.colors.top;
modifiedAttributes.tableCellBorder.top =
modifiedAttributes.tableBorder.top || docxDocumentInstance.tableBorders.size;
}

if (rowIndexEquivalentLast !== -1) {
// it means that the cell is in last row
// we set the bottom border of cells to that of table
modifiedAttributes.tableCellBorder.strokes.bottom =
modifiedAttributes.tableBorder.strokes.bottom;
modifiedAttributes.tableCellBorder.colors.bottom = modifiedAttributes.tableBorder.colors.bottom;
modifiedAttributes.tableCellBorder.bottom =
modifiedAttributes.tableBorder.bottom || docxDocumentInstance.tableBorders.size;
}

if (columnIndexEquivalentFirst !== -1) {
// it means that the cell is in first column
// we set the left border of cells to that of table
modifiedAttributes.tableCellBorder.strokes.left = modifiedAttributes.tableBorder.strokes.left;
modifiedAttributes.tableCellBorder.colors.left = modifiedAttributes.tableBorder.colors.left;
modifiedAttributes.tableCellBorder.left =
modifiedAttributes.tableBorder.left || docxDocumentInstance.tableBorders.size;
}

if (columnIndexEquivalentLast !== -1) {
// it means that the cell is in last column
// we set the right border of cells to that of table
modifiedAttributes.tableCellBorder.strokes.right = modifiedAttributes.tableBorder.strokes.right;
modifiedAttributes.tableCellBorder.colors.right = modifiedAttributes.tableBorder.colors.right;
modifiedAttributes.tableCellBorder.right =
modifiedAttributes.tableBorder.right || docxDocumentInstance.tableBorders.size;
}
// Apply table-level borders to all cells (edge and non-edge)
// This ensures that when borderOptions is set, all cells get borders creating a complete grid
// Individual cell styles (if present) can override these later in fixupTableCellBorder()
modifiedAttributes.tableCellBorder.strokes.top = modifiedAttributes.tableBorder.strokes.top;
modifiedAttributes.tableCellBorder.colors.top = modifiedAttributes.tableBorder.colors.top;
modifiedAttributes.tableCellBorder.top =
modifiedAttributes.tableBorder.top || docxDocumentInstance.tableBorders.size;

modifiedAttributes.tableCellBorder.strokes.bottom = modifiedAttributes.tableBorder.strokes.bottom;
modifiedAttributes.tableCellBorder.colors.bottom = modifiedAttributes.tableBorder.colors.bottom;
modifiedAttributes.tableCellBorder.bottom =
modifiedAttributes.tableBorder.bottom || docxDocumentInstance.tableBorders.size;

modifiedAttributes.tableCellBorder.strokes.left = modifiedAttributes.tableBorder.strokes.left;
modifiedAttributes.tableCellBorder.colors.left = modifiedAttributes.tableBorder.colors.left;
modifiedAttributes.tableCellBorder.left =
modifiedAttributes.tableBorder.left || docxDocumentInstance.tableBorders.size;

modifiedAttributes.tableCellBorder.strokes.right = modifiedAttributes.tableBorder.strokes.right;
modifiedAttributes.tableCellBorder.colors.right = modifiedAttributes.tableBorder.colors.right;
modifiedAttributes.tableCellBorder.right =
modifiedAttributes.tableBorder.right || docxDocumentInstance.tableBorders.size;

if (isVNode(vNode) && vNode.properties) {
if (vNode.properties.rowSpan) {
Expand Down
Loading
Loading