Repository navigation
Fix collision with palm leaves in Jarkendar - #1027
Closed
kroplabeskidu wants to merge 1 commit into
Closed
kroplabeskidu wants to merge 1 commit into
kroplabeskidu wants to merge 1 commit into
Conversation
vanilla shares materials by name and world mesh is loaded first, so its flags win. palm and tree leaves in jarkendar had collision because of that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #903
the "ferns" from the video are actually ADDON_PLANTS_SMALLPALM_02. leaf material NW_SEQ_NATURE_PALM_02 has collision on in the mrm, but the world mesh has a material with the same name and noCollDet set. vanilla looks materials up by name when loading a mesh and reuses the existing one, so the world flags win. same for ~40 palm/pine/tree leaf materials in addonworld
DynamicWorld now collects noCollDet materials from the world mesh and drops those parts from vob collision shapes, trunks and stones still collide. only did the disable direction, in oldworld 3 tree tops would get collision the other way around, left that alone