Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters api module #46

Merged
merged 9 commits into from
Mar 30, 2018
Merged

Add parameters api module #46

merged 9 commits into from
Mar 30, 2018

Conversation

youaresofunny
Copy link
Contributor

Параметры перенесены в отдельный модуль API, нужно для того, чтобы получать комиссии и не дергать много раз это в Operations.

@youaresofunny youaresofunny requested a review from roma219 March 29, 2018 16:29
// await transaction.set_required_fees()
// console.log(await transaction.broadcast());
// }
const getMemoPrice = (memo) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что это такое?

@@ -17,7 +18,13 @@ const getters = {
getPendingDistribution: state => state.pendingDistributionUpdate,
hasPendingTransfer: state => state.pendingTransfer !== false,
areTransactionsProcessing: state => state.transactionsProcessing,
getPendingTransfer: state => state.pendingTransfer
getPendingTransfer: state => state.pendingTransfer,
getMemoPrice: () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Зачем нужен этот геттер? 2) Так геттеры лучше не юзать, все таки они чисто для получения данных из стейта

@roma219 roma219 merged commit 8d06738 into master Mar 30, 2018
@roma219 roma219 deleted the AddParameters branch March 30, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants