Skip to content

fix: expose contracts#69

Merged
RishabhS7 merged 1 commit into
mainfrom
fix/expose-contracts
Jun 9, 2025
Merged

fix: expose contracts#69
RishabhS7 merged 1 commit into
mainfrom
fix/expose-contracts

Conversation

@nghaninn

@nghaninn nghaninn commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Summary

What is the background of this pull request?

  • export contracts for trustvc package

Summary by CodeRabbit

  • New Features
    • Expanded support for additional contract types and factories in both Token Registry v4 and v5 modules, enabling broader integration capabilities.

@coderabbitai

coderabbitai Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce new exports for contract factories and types in both the v4 and v5 token registry contract modules. Specifically, factories and types for TradeTrustTokenStandard and ERC1967-related contracts are now exported, with ERC1967 contracts aliased for clarity. No existing exports were removed or modified.

Changes

File(s) Change Summary
src/token-registry-v4/contracts.ts Added exports for TradeTrustTokenStandard__factory, ERC1967UpgradeUpgradeable__factory (as ERC1967__factory), and their corresponding types (with aliasing).
src/token-registry-v5/contracts.ts Added exports for TradeTrustTokenStandard__factory, ERC1967Utils__factory (as ERC1967__factory), and their corresponding types (with aliasing).

Poem

In the warren of code, new contracts appear,
Factories and types, now crystal clear.
V4 and V5, both get a boost,
ERC1967 hops in, let’s let loose!
The registry grows, with standards anew—
A rabbit’s delight in what code can do!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-09T09_02_49_636Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adb19a2 and c0c04d2.

📒 Files selected for processing (2)
  • src/token-registry-v4/contracts.ts (1 hunks)
  • src/token-registry-v5/contracts.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Tests / Test Build (20.x)
  • GitHub Check: Tests / Run Tests (18.x)
  • GitHub Check: Tests / Run Tests (20.x)
  • GitHub Check: Tests / Test Build (18.x)
  • GitHub Check: Linters / Commit Lint
  • GitHub Check: Linters / Code Lint (18.x)
  • GitHub Check: Linters / Code Lint (20.x)
  • GitHub Check: ESLint Review
🔇 Additional comments (4)
src/token-registry-v4/contracts.ts (2)

6-7: Expose additional v4 contract factories
New exports for TradeTrustTokenStandard__factory and the aliased ERC1967__factory have been added correctly.


14-15: Expose additional v4 contract types
The corresponding types TradeTrustTokenStandard and aliased ERC1967 are now exported, matching the factory updates.

src/token-registry-v5/contracts.ts (2)

6-7: Expose additional v5 contract factories
Exports for TradeTrustTokenStandard__factory and aliased ERC1967__factory (from ERC1967Utils__factory) align with the v4 pattern. Please confirm that aliasing ERC1967Utils__factory to ERC1967__factory is intentional and correctly reflects the underlying contract.


14-15: Expose additional v5 contract types
The types TradeTrustTokenStandard and aliased ERC1967 have been added consistently.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nghaninn nghaninn requested a review from RishabhS7 June 9, 2025 09:01
@RishabhS7 RishabhS7 merged commit c4e191d into main Jun 9, 2025
28 checks passed
@RishabhS7 RishabhS7 deleted the fix/expose-contracts branch June 9, 2025 09:06
nghaninn pushed a commit that referenced this pull request Jun 9, 2025
## [1.5.1](v1.5.0...v1.5.1) (2025-06-09)

### Bug Fixes

* expose contracts ([#69](#69)) ([c4e191d](c4e191d))
@nghaninn

nghaninn commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants