Skip to content

fix(invoice): extend instance TTL after state changes - #695

Open
abrcrmb wants to merge 1 commit into
TrusTrove:mainfrom
abrcrmb:fix/issue-559-ttl
Open

fix(invoice): extend instance TTL after state changes#695
abrcrmb wants to merge 1 commit into
TrusTrove:mainfrom
abrcrmb:fix/issue-559-ttl

Conversation

@abrcrmb

@abrcrmb abrcrmb commented Aug 29, 2026

Copy link
Copy Markdown

This PR fixes issue #559 by ensuring that set_pool_contract, set_agent_registry_contract, set_escrow_contract, add_supported_asset, and remove_supported_asset call Self::extend_instance_ttl(&env) after writing to instance storage, keeping them consistent with other mutators.

Closes #559

@abrcrmb
abrcrmb requested a review from K1NGD4VID as a code owner August 29, 2026 07:59
@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@abrcrmb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Needs changes

Indentation and conditional control flow are broken in set_pool_contract and set_agent_registry_contract due to misplaced closing braces around Self::extend_instance_ttl(&env).

  • contracts/invoice/src/lib.rs:165: Self::extend_instance_ttl(&env) is placed inside the else block with incorrect indentation and changes the control flow unexpectedly.
  • contracts/invoice/src/lib.rs:237: Self::extend_instance_ttl(&env) is placed inside the else block with incorrect indentation and changes the control flow unexpectedly.

Reviewed commit: 42e7506a1521ab5caf6e2dcb60c3f34e688ae57e.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

Indentation and conditional control flow are broken in set_pool_contract and set_agent_registry_contract due to misplaced closing braces around Self::extend_instance_ttl(&env).

  • contracts/invoice/src/lib.rs:165: Self::extend_instance_ttl(&env) is placed inside the else block with incorrect indentation and changes the control flow unexpectedly.
  • contracts/invoice/src/lib.rs:237: Self::extend_instance_ttl(&env) is placed inside the else block with incorrect indentation and changes the control flow unexpectedly.

Reviewed commit: 42e7506a1521ab5caf6e2dcb60c3f34e688ae57e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant