enhancement(invoice): emit events for supported assets and escrow config - #683
enhancement(invoice): emit events for supported assets and escrow config#683Ayomikun2005 wants to merge 4 commits into
Conversation
|
@Ayomikun2005 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Needs changes Tests are missing to verify that the new events are published correctly.
Reviewed commit: |
There was a problem hiding this comment.
Needs changes
Tests are missing to verify that the new events are published correctly as required by the acceptance criteria.
contracts/invoice/src/lib.rs: Acceptance criteria require tests asserting each event is published with expected topics/data, but no test changes were included in the PR diff.
Reviewed commit: 1c26c18300105e2793558006b516b6905622c828.
There was a problem hiding this comment.
Needs changes
Tests are missing to verify that the new events are published correctly.
contracts/invoice/src/lib.rs: Acceptance criteria require tests asserting that each event is published with the expected topics and data, but no tests were added in this PR.
Reviewed commit: 68cbe0bd10618b83493869ec8d6710db0503e128.
|
MergeKeeper review unavailable Automated review failed before a verdict was produced. No approval or merge action was taken. |
Ayomikun2005
left a comment
There was a problem hiding this comment.
I've added the missing tests in test.rs to ensure the new events are properly emitted, tested and verified! Please let me know if there's anything else required!
Summary
This PR addresses issue #560 assigned to me.
events.rsCloses #560
All tests pass.