Skip to content

enhancement(invoice): emit events for supported assets and escrow config - #683

Open
Ayomikun2005 wants to merge 4 commits into
TrusTrove:mainfrom
Ayomikun2005:fix/ayomikun2005-trustrove
Open

enhancement(invoice): emit events for supported assets and escrow config#683
Ayomikun2005 wants to merge 4 commits into
TrusTrove:mainfrom
Ayomikun2005:fix/ayomikun2005-trustrove

Conversation

@Ayomikun2005

Copy link
Copy Markdown

Summary

This PR addresses issue #560 assigned to me.

  • Added events , , and in events.rs
  • Emit in
  • Emit in
  • Emit in

Closes #560
All tests pass.

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@Ayomikun2005 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Needs changes

Tests are missing to verify that the new events are published correctly.

  • contracts/invoice/src/lib.rs: Acceptance criteria require tests asserting that each event is published with the expected topics and data, but no tests were added in this PR.

Reviewed commit: 68cbe0bd10618b83493869ec8d6710db0503e128.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

Tests are missing to verify that the new events are published correctly as required by the acceptance criteria.

  • contracts/invoice/src/lib.rs: Acceptance criteria require tests asserting each event is published with expected topics/data, but no test changes were included in the PR diff.

Reviewed commit: 1c26c18300105e2793558006b516b6905622c828.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

Tests are missing to verify that the new events are published correctly.

  • contracts/invoice/src/lib.rs: Acceptance criteria require tests asserting that each event is published with the expected topics and data, but no tests were added in this PR.

Reviewed commit: 68cbe0bd10618b83493869ec8d6710db0503e128.

@mergekeeper

mergekeeper Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

MergeKeeper review unavailable

Automated review failed before a verdict was produced.

No approval or merge action was taken.

@Ayomikun2005 Ayomikun2005 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the missing tests in test.rs to ensure the new events are properly emitted, tested and verified! Please let me know if there's anything else required!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhancement(invoice): add_supported_asset, remove_supported_asset, and set_escrow_contract emit no events

1 participant