Skip to content

fix: update HTTP status code for FailedPrecondition to 400 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 1 commit into from
Aug 26, 2025
Merged

fix: update HTTP status code for FailedPrecondition to 400 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
// PermissionDenied 403 Access denied
// Unauthenticated 401 Authentication required
// ResourceExhausted 429 Rate limit exceeded
// FailedPrecondition 422 Precondition failed
// FailedPrecondition 400 Precondition failed
// Aborted 409 Operation aborted
// OutOfRange 400 Value out of range
// Unimplemented 501 Not implemented
Expand Down
2 changes: 1 addition & 1 deletion error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ func (c Code) HttpStatusCode() int {
case CodeResourceExhausted:
return 429
case CodeFailedPrecondition:
return 422
return 400
case CodeAborted:
return 409
case CodeOutOfRange:
Expand Down
2 changes: 1 addition & 1 deletion error_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ func TestHTTPCodesMatchADR(t *testing.T) {
{trogonerror.CodePermissionDenied, 403, "PERMISSION_DENIED"},
{trogonerror.CodeUnauthenticated, 401, "UNAUTHENTICATED"},
{trogonerror.CodeResourceExhausted, 429, "RESOURCE_EXHAUSTED"},
{trogonerror.CodeFailedPrecondition, 422, "FAILED_PRECONDITION"},
{trogonerror.CodeFailedPrecondition, 400, "FAILED_PRECONDITION"},
{trogonerror.CodeAborted, 409, "ABORTED"},
{trogonerror.CodeOutOfRange, 400, "OUT_OF_RANGE"},
{trogonerror.CodeUnimplemented, 501, "UNIMPLEMENTED"},
Expand Down