Skip to content

fix: drop Windows support; recommend WSL#44

Merged
yordis merged 1 commit into
mainfrom
yordis/chore-drop-windows-support
May 29, 2026
Merged

fix: drop Windows support; recommend WSL#44
yordis merged 1 commit into
mainfrom
yordis/chore-drop-windows-support

Conversation

@yordis

@yordis yordis commented May 29, 2026

Copy link
Copy Markdown
Member
  • Maintaining a Windows build path forced us to carry parallel filesystem fallbacks (.workspace-ref, copy_skill_tree-as-symlink) and a degraded is_executable that never matched what Unix users rely on — paying that cost on every new feature isn't worth it when WSL2 already runs a real Linux kernel.
  • A compile_error! on non-Unix targets makes the policy explicit at build time; the README disclaimer points Windows users at WSL.

@cursor

cursor Bot commented May 29, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Policy and packaging change plus removal of Windows code paths; low runtime risk on supported platforms, but Windows/native MSVC consumers lose official binaries and must use WSL.

Overview
This PR drops native Windows support for trg and documents Linux/macOS only, with Windows users directed to WSL.

A compile_error! on non-Unix targets in lib.rs fails the build on Windows instead of shipping degraded behavior. crates/trg/README.md states the platform policy and WSL guidance; Cargo.toml wires that file as the crate readme.

Release CI no longer builds or packages x86_64-pc-windows-msvc (matrix entry, zip packaging, and archive flags removed). Unix release tarballs now bundle crates/trg/README.md instead of the repo root README.

Unix-only paths replace #[cfg(unix)] / #[cfg(not(unix))] branches: docs mirror layout always uses symlinks with .workspace-ref on failure; eval workspaces symlink skills (no Windows copy fallback); runner discovery checks executable bits via Unix permissions. Tests assume symlinks and chmod without platform guards.

Reviewed by Cursor Bugbot for commit 61869ff. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 11 minutes and 31 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33ee8bb3-1264-4bc2-98ce-c5f41b234a03

📥 Commits

Reviewing files that changed from the base of the PR and between bf53675 and 61869ff.

📒 Files selected for processing (9)
  • .github/workflows/release-artifacts.yml
  • crates/trg/Cargo.toml
  • crates/trg/README.md
  • crates/trg/src/agentskills/grading.rs
  • crates/trg/src/agentskills/layout.rs
  • crates/trg/src/agentskills/runner/availability.rs
  • crates/trg/src/agentskills/runner/mod.rs
  • crates/trg/src/commands/ai/skills/eval/grade.rs
  • crates/trg/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-drop-windows-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis
yordis force-pushed the yordis/chore-drop-windows-support branch from b7bc124 to 4c7f5b9 Compare May 29, 2026 06:33
Maintaining a Windows build path forced us to carry parallel filesystem fallbacks (`.workspace-ref`, `copy_skill_tree`-as-symlink) and a degraded `is_executable` that never matched what Unix users rely on. Paying that cost on every new feature isn't worth it when WSL2 already runs a real Linux kernel.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/chore-drop-windows-support branch from 4c7f5b9 to 61869ff Compare May 29, 2026 06:34
@yordis yordis changed the title chore: drop Windows support; recommend WSL fix: drop Windows support; recommend WSL May 29, 2026
@yordis

yordis commented May 29, 2026

Copy link
Copy Markdown
Member Author

for everyone wonder in the future, sorry, I don't have a Window computer since 2013, and with WSL, you can get the benefits as well.
I do not have interest to sunk time into maintaining Windows by now.

@yordis
yordis merged commit 9c1960d into main May 29, 2026
12 checks passed
@yordis
yordis deleted the yordis/chore-drop-windows-support branch May 29, 2026 06:49
yordis added a commit that referenced this pull request May 29, 2026
After #44 dropped Windows support, lingering doc references to a Windows
copy-fallback path and to Windows credential backends misled readers about
what the runtime actually does.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant