fix: remove redundant component name from archive template - #18
Conversation
|
Warning Rate limit exceeded@yordis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
f70fca6 to
645b13d
Compare
The archive name was duplicating the component name: - Before: protoc-gen-elixir-grpc_protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz - After: protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz Since .Version now contains the full monorepo tag (component@version), we don't need to prefix it with BUILD_COMPONENT. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
645b13d to
a5abaea
Compare
Problem
Archive names are unnecessarily long and duplicate the component name:
Root Cause
The GoReleaser archive template was using:
{{ .Env.BUILD_COMPONENT }}_{{- .Version }}_...Where:
BUILD_COMPONENT=protoc-gen-elixir-grpc.Version=protoc-gen-elixir-grpc@v0.2.0(full monorepo tag)This resulted in the component name appearing twice.
Solution
Remove the
{{ .Env.BUILD_COMPONENT }}prefix from the archive template since.Versionalready contains the full monorepo tag format.Result
Cleaner archive names:
Testing
Validated locally with:
BUILD_COMPONENT="protoc-gen-elixir-grpc" goreleaser release --snapshot --skip=validate