-
Notifications
You must be signed in to change notification settings - Fork 2
fix(trogonstack-datadog): reconcile Customer-Facing group with I/P/D prefix convention #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5edcd47
fix(trogonstack-datadog): reconcile Customer-Facing group with I/P/D …
yordis 136932a
fix(trogonstack-datadog): introduce B (Business) as a proper 4th layer
yordis 4bf60b2
fix(trogonstack-datadog): propagate I/P/D/B layer system to design-da…
yordis 9dd689b
fix(trogonstack-datadog): clarify D vs B layer distinction as tech vs…
yordis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infrastructure metrics incorrectly re-prefixed as Business layer
Medium Severity
Several infrastructure metrics in layout templates were blindly re-prefixed from
ItoBwhen the "Customer-Facing" group was renamed to "Business." Specifically:B1: DB conn pool(lines 74, 250) was formerlyI0: DB conn pool, andB0: Host avail./B1: Network errors(line 136) were formerlyI0:prefixed. These are infrastructure metrics per the classification guide inwidgets.md(databases, networks, OS resources), not business outcomes. Thewidgets.mdexamples were updated correctly to exclude non-B metrics from the Business group, but the layout templates were not — creating an internal inconsistency that will confuse the AI skill and produce incorrectly classified dashboards.Additional Locations (2)
plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md#L135-L136plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md#L249-L250