Skip to content

Skip 0 duration rects when generating output svg's #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip 0 duration rects when generating output svg's #50

wants to merge 1 commit into from

Conversation

@davidrusu
Copy link

@davidrusu davidrusu commented Oct 21, 2018 •
edited
Loading

Ran into an issue when trying to process a state map similar to this one:

{"start":[1533843905,0],"states":{"a":{"value":0,"color":"#be78ed"},"b":{"value":1,"color":"#edbf4b"}},"title":"test"}
{"entity":"e1","state":0,"tag":"4","time":"47000000000"}
{"entity":"e1","state":0,"tag":"3","time":"51000000000"}
{"entity":"e1","state":0,"tag":"2","time":"51000000000"}

statemap would die with an assertion failure

davidrusu
davidrusu commented Oct 21, 2018
View reviewed changes
src/statemap.rs
let rect = self.rects[&rect_start].borrow();
if rect.duration == 0 {
// discard this rectangle since it has 0 width
continue;
Copy link
Author

@davidrusu davidrusu Oct 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only semantic change, rest is some cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidrusu