feat: add validation for OpenAI API key and assistant ID in story poi…#409
Open
onurkanbakirci wants to merge 3 commits into
Open
feat: add validation for OpenAI API key and assistant ID in story poi…#409onurkanbakirci wants to merge 3 commits into
onurkanbakirci wants to merge 3 commits into
Conversation
onurkanbakirci
requested review from
aahmetcakir,
armagandalkiran and
mertcanaltin
as code owners
September 10, 2025 16:03
|
@onurkanbakirci is attempting to deploy a commit to the Trendyol Gurubu Team Team on Vercel. A member of the Team first needs to authorize it. |
mertcanaltin
left a comment
mertcanaltin
left a comment
Member
There was a problem hiding this comment.
open api key is actually already read from vercel variables section
Contributor
Author
|
What about the Jira-related keys and |
Comment on lines
+8
to
+10
| if (!process.env.OPENAI_API_KEY) { | ||
| throw new Error('OPENAI_API_KEY environment variable is required'); | ||
| } |
Member
There was a problem hiding this comment.
In cases where there is no API, we should not interrupt the application with a throw; we can discuss a better approach, such as a catch scenario and a user-friendly flow.
Member
|
Please use a shorter and more appropriate commit message. Additionally, I agree that APIs are already stored as env values, so I don't think there's a major issue here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing API Key validation:
gurubu-backend/services/openaiService.jsusesprocess.env.OPENAI_API_KEYwithout checking if it existsMissing Assistant ID validation:
gurubu-backend/controllers/storyPointEstimationController.jsusesprocess.env.OPENAI_ASSISTANT_IDwithout validation