You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the background of this pull request?
Change the from block number logic so that TradeTrust starts fetching from the block number when it was integrated into the XDC Network, instead from the genesis block. This will ensure faster and efficient responses.
Changes
Added blockNumber field to chain info. It is an optional parameter for any chains to use.
Updated the functions to use this blockNumber instead from the genesis block to query
Updated the Integration tests with additional parameter
Issues
View endorsement chain during verification of document fails as it requires archival node to fetch complete history and fetches data from genesis block
We are currently benchmarking and seeking opportunities to improve our view endorsement chain.
However, I am encountering inconsistent delays, way longer than usual, in some operations using the RPC URL provided by the XDC team. These inconsistencies make it difficult to compare the overall durations of the view endorsement chain before and after optimizations. Could the XDC team assist us by providing a stable RPC URL?
Regarding the changes in querying the blockchain starting from a specific block number, may I know in detail how much the view endorsement chain process on XDC improves? We need to determine if the cost of changing the code and adding extra complexity outweighs the efficiency gains. When I tested it on Sepolia, I did not see significant improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the background of this pull request?
Change the from block number logic so that TradeTrust starts fetching from the block number when it was integrated into the XDC Network, instead from the genesis block. This will ensure faster and efficient responses.
Changes
Issues
View endorsement chain during verification of document fails as it requires archival node to fetch complete history and fetches data from genesis block