Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a self-healing Redis connection pool (
RecoverablePool) that automatically detects and replaces failed connections without disrupting ongoing operations. When a connection fails, the pool transparently creates a new client, establishes the connection, and swaps it into the pool—making Redis connection failures invisible to the caller.Important
This PR is an extension of #2067, should be merged after, and needs to be tested with real world workloads of our customers. It may break. A couple obvious risks in this implementation are:
Key changes:
Poolwith customRecoverablePoolthat supports on-demand client replacementType of change
How Has This Been Tested?
RecoverablePoolbazel test //nativelink-store:integration_tests/redis_store_test_testpassesChecklist
bazel test //...passes locallygit amendsee some docsThis change is