Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on launch due to memory usage spike #1123

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Fix crash on launch due to memory usage spike #1123

merged 1 commit into from
Mar 30, 2024

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • The app keeps getting killed by iOS due to high memory usage, this is because the current logic to load a folder's artwork was letting any file pass in like it was an image (like the mp3s or the m4bs), so it would load up the entire file in memory for each folder that didn't have the artwork cached, leading to the spike in memory usage

Related tasks

#1118

Approach

  • Fix validation when checking for an internal image file

@GianniCarlo GianniCarlo self-assigned this Mar 30, 2024
@GianniCarlo GianniCarlo merged commit 5ba6f9c into develop Mar 30, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the fix-crash-launch branch March 30, 2024 05:16
@GianniCarlo GianniCarlo mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo