Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid storing S3 error downloads as files #1115

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Avoid storing S3 error downloads as files #1115

merged 5 commits into from
Mar 8, 2024

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • When there's an error downloading a cloud file, due to expired links, or the file not being available, the URLSession does not throw an error, it just completes

Related tasks

#1081

Approach

  • Check for the status code of the URLSessionTask, and manually determine the error from there

Things to be aware of / Things to focus on

  • This also fixes some issues with alerts being shown in a background thread on the Storage management screen, and if there was an error initializing the database on launch

@GianniCarlo GianniCarlo self-assigned this Mar 7, 2024
@GianniCarlo GianniCarlo merged commit d6575ec into develop Mar 8, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the fix-s3-error branch March 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo