-
Notifications
You must be signed in to change notification settings - Fork 12
ci: Add MPS testing #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: Add MPS testing #490
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
Quite a few things fail because some operations are not yet supported on MPS. They either raise a NotImplementedError, which we now catch, or they raise a warning, which is not so convenient to catch (still need to fix those cases). See pytorch/pytorch#141287 for the status of this on PyTorch side. Also, in some cases, we get small numerical errors that make the test fail. Lastly, some ConFIG tests seem to fail by a large margin. |
There are three main goals with this PR:
device=...are properly tested throughout torchjd. Forgetting one of them is the most likely cause of error that would not be caught when testing only on CPU when developing new things. Since this is the same for MPS and cuda, it basically fixes half of the problem of not running the CI on GPU. (The other half is that some device-specific function could behave differently or not even exist on some device, which would make the tests fail if we run them on this device. We cannot test that without running on these device types.)