Skip to content

Conversation

@noreenko
Copy link

@noreenko noreenko commented Jun 24, 2024

1.5 update seems to call get_CanBleed a TON. TM_Calc.IsUndead takes about .002 ms to complete in steam version. These changes remove harmony overhead and the extra checks that are not needed. The extra XML changes that aren't bloodDefs are just indentations.

My reasoning for removing the checks in IsUndead is:

  • Races can just set a bloodDef instead in the XML
  • The trait seems always to be applied with the hediff, so checking seems redundant. I would rather check the trait, but unfortunately there are a lot of things that don't get the trait, like animals.

I do intend to take another pass at this at some point, but for now it is at least significantly faster than what is on steam. I would like to remove the transpiler, because they're hard to read, but I think this one might have to stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant