fix: don't account for empty attributes

src/detector.impressions.test.ts

@@ -34,3 +34,19 @@ test("check impresssions", async () => {
     },
   ]);
 });
+
+test("don't consider empty attributes", async () => {
+  window.TS = {
+    token: "token",
+  };
+  const events: any[] = [];
+  window.addEventListener("topsort", (e) => {
+    events.push((e as any).detail);
+  });
+  document.body.innerHTML = `
+    <div data-ts-resolved-bid=""></div>
+  `;
+  await import("./detector");
+
+  expect(events).toMatchObject([]);
+});

src/detector.ts

@@ -1,4 +1,4 @@
 import { type Config, Entity, TopsortClient, Event as TopsortEvent } from "@topsort/sdk";
 import { version } from "../package.json";
 import { ProcessorResult, Queue } from "./queue";
 import { truncateSet } from "./set";
@@ -249,27 +249,27 @@
 
 const intersectionObserver = !!window.IntersectionObserver
   ? new IntersectionObserver(
-      (entries) => {
-        for (const entry of entries) {
-          if (entry.isIntersecting) {
-            const node = entry.target;
-            if (node instanceof HTMLElement) {
-              logEvent(getEvent("Impression", node), node);
-              if (intersectionObserver) {
-                intersectionObserver.unobserve(node);
-              }
+    (entries) => {
+      for (const entry of entries) {
+        if (entry.isIntersecting) {
+          const node = entry.target;
+          if (node instanceof HTMLElement) {
+            logEvent(getEvent("Impression", node), node);
+            if (intersectionObserver) {
+              intersectionObserver.unobserve(node);
             }
           }
         }
-      },
-      {
-        threshold: INTERSECTION_THRESHOLD,
-      },
-    )
+      }
+    },
+    {
+      threshold: INTERSECTION_THRESHOLD,
+    },
+  )
   : undefined;
 
 const PRODUCT_SELECTOR =
-  "[data-ts-product],[data-ts-action],[data-ts-items],[data-ts-resolved-bid]";
+  '[data-ts-product]:not([data-ts-product=""]),[data-ts-action]:not([data-ts-action=""]),[data-ts-items]:not([data-ts-items=""]),[data-ts-resolved-bid]:not([data-ts-resolved-bid=""])';
 
 function addClickHandler(node: HTMLElement) {
   const clickables = node.querySelectorAll("[data-ts-clickable]");