Implement XdrCodec for TransactionMeta#108
Open
OluRemiFour wants to merge 1 commit intoToolbox-Lab:mainfrom
Open
Implement XdrCodec for TransactionMeta#108OluRemiFour wants to merge 1 commit intoToolbox-Lab:mainfrom
OluRemiFour wants to merge 1 commit intoToolbox-Lab:mainfrom
Conversation
|
@OluRemiFour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #108 |
Emrys02
approved these changes
Mar 28, 2026
Contributor
Emrys02
left a comment
Emrys02
left a comment
There was a problem hiding this comment.
@OluRemiFour PR reviewed
Contributor
|
@OluRemiFour please fix conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #85
Implemented XdrCodec for stellar_xdr::curr::TransactionMeta in codec.rs (line 10). The new trait exposes base64 XDR decode/encode helpers, and the TransactionMeta impl uses stellar-xdr’s ReadXdr/WriteXdr APIs with Limits::none() so the app can deserialize transaction meta into programmatic types.
I also added round-trip coverage for TransactionMeta v0 and v1 in codec.rs (line 119) and cleaned up a duplicate base64 decode in the same module.