Skip to content

Don't panic if a write doesn't fully complete #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thenickdude wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't panic if a write doesn't fully complete #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ class Speaker extends Writable {
// close() has already been called. this should not be called
return done(new Error('write() call after close() call'))
}
let b
let left = chunk
let handle = this.audio_handle
if (!handle) {
Expand All @@ -187,13 +186,12 @@ class Speaker extends Writable {
debug('aborting remainder of write() call (%o bytes), since speaker is `_closed`', left.length)
return done()
}
b = left
let b = left
if (b.length === 0) {
return done()
}
if (b.length > chunkSize) {
const t = b
b = t.slice(0, chunkSize)
left = t.slice(chunkSize)
} else {
left = null
b = b.slice(0, chunkSize)
}
debug('writing %o byte chunk', b.length)
binding.write(handle, b).then(onwrite, onerror)
Expand All @@ -205,9 +203,10 @@ class Speaker extends Writable {

const onwrite = (r) => {
debug('wrote %o bytes', r)
if (r !== b.length) {
if (r <= 0) {
done(new Error(`write() failed: ${r}`))
} else if (left) {
} else if (r < left.length) {
left = left.slice(r)
debug('still %o bytes left in this chunk', left.length)
write()
} else {
Expand Down