NTLS证书问题 #24
Closed
NTLS证书问题 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongbeiouba
requested changes
Jul 27, 2024
| } | ||
|
|
||
| result := C.GoBytes(unsafe.Pointer(ptr), C.int(length)) | ||
| runtime.KeepAlive(key) |
There was a problem hiding this comment.
runtime.KeepAlive(key)确保在转换过程中,key对象不会被垃圾回收。
ntls_test.go
Outdated
| @@ -32,15 +32,15 @@ func TestNTLS(t *testing.T) { | |||
| { | |||
| cipher: ECCSM2Cipher, | |||
| runServer: internalServer, | |||
| caFile: filepath.Join(testCertDir, "chain-ca.crt"), | |||
| caFile: filepath.Join(testCertDir, "chain-ca1.crt"), | |||
test/certs/sm2/chain-ca1.crt
Outdated
crypto/cert_test.go
Outdated
| } | ||
|
|
||
| // 创建 CA 证书 | ||
| caKey := generateAndSaveKey("./../test/certs/sm2/ca.key") |
There was a problem hiding this comment.
测试用例中生成的文件不要覆盖仓库中已有的文件，可以搞成临时文件，或者在测试用例结束时清理。
下同。
There was a problem hiding this comment.
没有覆盖仓库中已有的文件，新生成的文件都是在原有文件的命名基础上加1
# Conflicts: # crypto/key.go
# Conflicts: # crypto/cert_test.go
# Conflicts: # crypto/cert_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.