Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ntls client and server example; Add API conn.GetVersion() #14

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

dongbeiouba
Copy link
Member

No description provided.

@itomsawyer
Copy link
Collaborator

Only one main func can be defined in the same package . Please move ntls_client and ntls_server into sepereted package (e.p. examples/client/ntls_client.go examples/server/ntls_server.go )

Copy link
Member

@InfoHunter InfoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @itomsawyer said is correct, so that needs to be fixed...

@dongbeiouba
Copy link
Member Author

Only one main func can be defined in the same package . Please move ntls_client and ntls_server into sepereted package (e.p. examples/client/ntls_client.go examples/server/ntls_server.go )

Fixed.

Copy link
Collaborator

@itomsawyer itomsawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itomsawyer itomsawyer merged commit 6d0268c into Tongsuo-Project:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants