Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #70: add methods to remove widgets from forms #93

Merged
merged 29 commits into from
Oct 30, 2023
Merged

Closes #70: add methods to remove widgets from forms #93

merged 29 commits into from
Oct 30, 2023

Conversation

DanicaSTFC
Copy link
Collaborator

@DanicaSTFC DanicaSTFC commented Oct 17, 2023 •
edited
Loading

  • Adds method to remove widgets from forms.
  • Adds method to extract the number of widgets from forms.
  • Adds addSpanningWidget method to FormDockWidget.
  • Adds example to remove widgets from the FormDialog and the FormDockWidget.
  • Adds the unit test for the removal of widgets from the forms.

@DanicaSTFC
Add function to hide widgets
2d4672f
@DanicaSTFC
Add function to remove widgets
d629b40
@DanicaSTFC
Remove widgets with name and getWidget
00f5793
@DanicaSTFC
Example shows 3 widgets and they are removed by the user
b4c7402
@DanicaSTFC
RemoveWidget added to class FormDockWidget and UIFormWidget
f8b6715
@DanicaSTFC
Remove spanning widget functionality
cbd2341
@DanicaSTFC
Fix dictionary and add example for FormDockWidget
241775c
@DanicaSTFC
Add title to FormDockWidget
9c21e2c
@DanicaSTFC
Remove function substitute from deleteLater to removeRow
50faf7f
@DanicaSTFC
Add unit test remove every widget
224ffe3
@DanicaSTFC
Add unit test to remove widget with layout input
538006e
@DanicaSTFC
Fix total number of widgets in the form after widget is removed
eb778a1
@DanicaSTFC
Add method extract number of widgets in the forms
bc243ee
@DanicaSTFC
Layout add in the setup and unit test accomodated for layout and widg…
a8d3e6b 
…et number
@DanicaSTFC
Add layout's number of rows assertion in the unit test
8b5cfa2
@DanicaSTFC
Merge branch 'main' of github.com:TomographicImaging/eqt into remove-…
7145548 
…widget-from-form
@DanicaSTFC
Change some comments
c60c400
@DanicaSTFC
Copy link
Collaborator Author

Please review and I will delete/fix the comments during the review process.

lauramurgatroyd
lauramurgatroyd requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just made some suggestions

lauramurgatroyd
lauramurgatroyd approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

My only suggestion is that the dialog example could be improved slightly. I found that if the spanning widget is removed, then it is not clear that the ok button will remove the "user input" widget:
image

Could be fixed with the addition of a simple extra line of text.

@DanicaSTFC DanicaSTFC merged commit ec2c5a1 into main Oct 30, 2023
@DanicaSTFC DanicaSTFC deleted the remove-widget-from-form branch October 30, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramurgatroyd lauramurgatroyd lauramurgatroyd approved these changes

@paskino paskino Awaiting requested review from paskino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanicaSTFC @paskino @lauramurgatroyd