-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QLineEdit support to UISliderWidget #168
Draft
jcornall
wants to merge
20
commits into
main
Choose a base branch
from
uislider-dspinbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanicaSTFC
requested changes
Dec 17, 2024
jcornall
changed the title
Add QDoubleSpinBox support to UISliderWidget
Add QLineEdit support to UISliderWidget
Dec 19, 2024
Updated PR title to reflect changes to the design of the UISliderWidget class. Following discussions with @paskino and @DanicaSTFC, it was agreed that instead of a QDoubleSpinBox the UISliderWidget class would make better use of a QLineEdit, removing restrictions on the decimal values users can input. |
update docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125 #60
The current UISliderWidget is limited due to the following factors:
This pull request removes the QLabel parameter in favour of a QDoubleSpinBox parameter, which displays the current value of the slider, can be manually edited (supports float/double values), and updates when the slider value is changed.
An example has been included in the /examples/ folder to demonstrate the functionality.
PLEASE NOTE: By default the
QSlider.value()
only supports integer values - even if the value of the QDoubleSpinBox is a float/double, this value is automatically converted to an integer when the slider value is updated. I am investigating solutions to this problem so that the slider value accurately reflects that of the QDoubleSpinBox.Current Tasks:
Overload the init, one with the DSpinBox and one without