Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename /scripts and update CONTRIBUTING.md #161

Merged
merged 11 commits into from
Nov 30, 2024
Merged

Rename /scripts and update CONTRIBUTING.md #161

merged 11 commits into from
Nov 30, 2024

Conversation

jcornall
Copy link
Collaborator

@jcornall jcornall commented Nov 26, 2024 •
edited by DanicaSTFC
Loading

Closes #160 #159

@jcornall jcornall self-assigned this Nov 26, 2024
DanicaSTFC
DanicaSTFC requested changes Nov 26, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
scripts/eqt_env.yml Show resolved Hide resolved
DanicaSTFC
DanicaSTFC requested changes Nov 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
recipe/eqt_env.yml Outdated Show resolved Hide resolved
@DanicaSTFC DanicaSTFC linked an issue Nov 27, 2024 that may be closed by this pull request
Examples do not run or display incorrectly #160
Closed
@jcornall jcornall marked this pull request as ready for review November 27, 2024 11:37
@jcornall jcornall requested a review from DanicaSTFC November 27, 2024 11:52
DanicaSTFC
DanicaSTFC requested changes Nov 27, 2024
View reviewed changes
recipe/eqt_env.yml Outdated Show resolved Hide resolved
@DanicaSTFC DanicaSTFC linked an issue Nov 27, 2024 that may be closed by this pull request
Improve the recipe and installation guidelines #159
Closed
DanicaSTFC
DanicaSTFC requested changes Nov 29, 2024
View reviewed changes
recipe/eqt_env.yml Outdated Show resolved Hide resolved
@DanicaSTFC DanicaSTFC mentioned this pull request Nov 29, 2024
Open
@jcornall
Copy link
Collaborator Author

Tested eqt using different versions of Python:

  • Python 3.11.6 (installed via conda install python=3.11.6 command)
  • Python 3.11.10 (installed using mamba env create -f recipe/eqt_env.yml)

Both work. 3.11.10 is the latest version of Python that can be installed with the current recipe limitation (python <3.12).

@jcornall jcornall requested a review from DanicaSTFC November 29, 2024 17:21
@DanicaSTFC DanicaSTFC added this to the Version x.x.x milestone Nov 29, 2024
@jcornall jcornall merged commit 0291f7f into main Nov 30, 2024
6 checks passed
@jcornall jcornall deleted the update-recipe branch November 30, 2024 21:18
@DanicaSTFC DanicaSTFC mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanicaSTFC DanicaSTFC DanicaSTFC approved these changes

Assignees

@jcornall jcornall

Labels
None yet
Projects
None yet
Milestone
Version 1.0.2
Development

Successfully merging this pull request may close these issues.

Examples do not run or display incorrectly Improve the recipe and installation guidelines
2 participants
@jcornall @DanicaSTFC