Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set title correctly in the class FormDockWidget #102

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Set title correctly in the class FormDockWidget #102

merged 9 commits into from
Nov 30, 2023

Conversation

DanicaSTFC
Copy link
Collaborator

@DanicaSTFC DanicaSTFC commented Nov 8, 2023 •
edited
Loading

Closes #101.

  • Change the init in the class FormDockWidget so the title is passed correctly.
  • Modify example remove_widgets_example to check functionality.
  • Add unit test test_form_init_title to FormDialog and FormDockWidget to test that the form is created correctly with or without the title input.

@DanicaSTFC DanicaSTFC requested a review from paskino November 8, 2023 16:56
lauramurgatroyd
lauramurgatroyd requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing this, can't we pass this on to the QDockwidget's init?
So on line 340 if title is not None, pass it to the init?

lauramurgatroyd
lauramurgatroyd requested changes Nov 20, 2023
View reviewed changes
examples/remove_widgets_example.py Show resolved Hide resolved
eqt/ui/UIFormWidget.py Outdated Show resolved Hide resolved
@DanicaSTFC DanicaSTFC added this to the v1.0.0 milestone Nov 22, 2023
lauramurgatroyd
lauramurgatroyd reviewed Nov 23, 2023
View reviewed changes
test/test__formUI_status_test.py Outdated Show resolved Hide resolved
eqt/ui/UIFormWidget.py Outdated Show resolved Hide resolved
@DanicaSTFC DanicaSTFC changed the title Fix bug on set title in the class FormDockWidget Set title correctly in the class FormDockWidget Nov 30, 2023
@DanicaSTFC DanicaSTFC merged commit cd81441 into main Nov 30, 2023
6 checks passed
@DanicaSTFC DanicaSTFC deleted the dockwidgetform-set-window-title branch November 30, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramurgatroyd lauramurgatroyd lauramurgatroyd approved these changes

@paskino paskino Awaiting requested review from paskino

Assignees

@lauramurgatroyd lauramurgatroyd

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

DockWidgetForm does not set window title correctly
2 participants
@DanicaSTFC @lauramurgatroyd