Fix HDF5 cropped reader #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
…ing/CILViewer into fix-cilHDF5CroppedReader
paskino
approved these changes
Mar 2, 2025
| reader = HDF5SubsetReader() | ||
| reader.SetInputConnection(full_reader.GetOutputPort()) | ||
| # Either the TargetExtent or TargetZExtent should have been set. | ||
| # We prioritise the TargetExtent | ||
| if self.GetTargetExtent() is None: | ||
| extent = [0, -1, 0, -1, self.GetTargetZExtent[0], self.GetTargetZExtent[1]] | ||
| extent = [ |
There was a problem hiding this comment.
I think this should actually use the extent rather than the dimensions, but it should be fine for the time being. Maybe we should later add an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Describe any testing you have performed
Consider adding example code to examples
I tested this on the idvc app, in the registration tab we crop the image.
Link relevant issues
cilHDF5CroppedReaderdoes not work #461Checklist when you are ready to request a review
Contribution Notes
Qt contributions should follow Qt naming conventions i.e. camelCase method names.
VTK contributions should follow VTK naming conventions i.e. PascalCase method names.