Skip to content

First run: the first skill step opens the catalog - #180

Open
TommyBez wants to merge 1 commit into
mainfrom
gtm/first-skill-step-to-discover
Open

First run: the first skill step opens the catalog#180
TommyBez wants to merge 1 commit into
mainfrom
gtm/first-skill-step-to-discover

Conversation

@TommyBez

@TommyBez TommyBez commented Sep 4, 2026

Copy link
Copy Markdown
Owner

What changes

On /start, the "Add your first skill" card now leads to the public catalog.

  • Primary button: "Browse the catalog", to /discover.
  • Secondary outline button beside it: "Add from a repository", to /library.
  • The description no longer assumes the reader has a GitHub repository URL in hand.
  • onboarding_step_clicked gains an optional destination property (discover or library), set only by the first-skill step. Older events have no destination and meant /library.
  • A test asserts both hrefs and both destinations.

Why

Since 23 August we created 7 teams. 5 of them saw /start. 2 clicked the first-skill step, which sent them to /library: an empty library whose empty state then offers "Add a skill" (a GitHub repository dialog) or "Find skills" (a link to /discover). One of those two teams walked that extra hop, reached /discover and saved 3 skills in 4 minutes. The other landed on the empty page and left. 6 of the 7 teams are still at 0 skills.

The only team that saved anything did it from the catalog, and the step that was meant to produce a first skill was pointing at the one page that has nothing in it yet.

Hypothesis

A new team has no repository URL ready, but it can recognize a useful skill in a catalog and save it in one click. Landing the first-skill step on /discover should turn more clicks on that step into a first saved skill. Keeping the repository path visible as a secondary button costs the people who do have a URL only one extra click.

Metric that should move

  • onboarding_step_clicked with step=first_skill followed by skill_saved in the same session.
  • The share of new teams with at least one skill within 14 days of creation, currently 1 of 7.

Secondary, for reading the split: the destination property on the step event tells us how many people want the catalog versus the repository path.

How we will know

Compare teams created after the merge with the 7 created before it. At 4 or 5 new teams a month, a readable difference will take weeks and the numbers will stay noisy the whole time. This is a directional bet on a broken step, not a measurable experiment; do not expect significance.

Checks

  • node --test tests/*.test.mjs: 586 tests, all passing.
  • tsc --noEmit -p .: clean.
  • No production build was run: the sandbox disk is full. The build is verified by the Vercel preview deploy on this PR.

Summary by CodeRabbit

  • New Features

    • Onboarding now directs users to the public catalog as the primary way to add their first skill.
    • Added a secondary option to browse the skill library.
    • Each destination is tracked separately for improved analytics.
  • Tests

    • Added coverage verifying onboarding links and destination-specific tracking.

The step sent people to their own library, which on day zero is empty. It now
opens /discover, where saving a skill is one click, and keeps the GitHub
repository path as a secondary button. The event records which destination was
taken.
@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
skillsboard Ready Ready Preview, v0 Sep 4, 2026 1:03pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a1ced429-afb8-4477-8375-eafa9db8115b

📥 Commits

Reviewing files that changed from the base of the PR and between 7577e30 and 8ad6f62.

📒 Files selected for processing (3)
  • analytics/posthog/events.ts
  • components/onboarding-next-steps.tsx
  • tests/agent-first-connect.test.mjs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The first-skill onboarding step now opens /discover as the primary destination and keeps /library as a secondary option. Each link emits destination-specific onboarding_step_clicked analytics, and tests validate both destinations.

Changes

Catalog-first onboarding flow

Layer / File(s) Summary
Destination analytics contract
analytics/posthog/events.ts
The onboarding_step_clicked event now accepts optional "discover" or "library" destinations.
Onboarding links and validation
components/onboarding-next-steps.tsx, tests/agent-first-connect.test.mjs
The first-skill step links to /discover and /library, records each destination, updates its documentation, and tests both paths and payloads.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8ad6f

The first-skill onboarding card now prioritizes the catalog while retaining repository import, with destination-specific analytics and coverage for both paths. No concrete current-head merge risk remains.

Poem

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description gives detailed context, rationale, metrics, and validation results. However, it does not follow the repository template: it uses "What changes" instead of "What changed," omits the req… Rename "What changes" to "What changed" and add the required "Validation" and "Impact" sections. Include the validation checklist, document that no database or environment changes exist, confirm that no secrets or private skill content are …
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: the first-skill onboarding step now opens the catalog.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description gives detailed context, rationale, metrics, and validation results. However, it does not follow the repository template: it uses "What changes" instead of "What changed," omits the required "Validation" and "Impact" sections, and does not provide the required impact checklist information.

Resolution

Rename "What changes" to "What changed" and add the required "Validation" and "Impact" sections. Include the validation checklist, document that no database or environment changes exist, confirm that no secrets or private skill content are included, and confirm that saved-skill ownership is unchanged.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gtm/first-skill-step-to-discover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T13:05:08.889550Z 8ad6f62 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TommyBez

TommyBez commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant