Skip to content

fix(status): notify only when root session completes#104

Merged
TomCC7 merged 2 commits into
mainfrom
feature/rapid-uplink-747
Feb 26, 2026
Merged

fix(status): notify only when root session completes#104
TomCC7 merged 2 commits into
mainfrom
feature/rapid-uplink-747

Conversation

@TomCC7

@TomCC7 TomCC7 commented Feb 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Restrict completion notifications to confirmed root-session running-to-idle transitions by adding should_notify_root_session_completion in the status-match path.
  • Remove completion notifications from fallback idle transitions (repo unavailable, missing session, and status-fetch error) while preserving needs_inspection updates.
  • Add unit coverage for root-only notification gating in src/app/polling.rs.

Verification

  • cargo test --lib app::polling
  • cargo build

@TomCC7 TomCC7 merged commit adf4fb4 into main Feb 26, 2026
3 checks passed
@TomCC7 TomCC7 deleted the feature/rapid-uplink-747 branch February 26, 2026 21:17
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.35052% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/app/polling.rs 78.35% 21 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants