Skip to content

feat(settings): configure tmux notification display duration#103

Merged
TomCC7 merged 1 commit into
mainfrom
feat/done-notification
Feb 26, 2026
Merged

feat(settings): configure tmux notification display duration#103
TomCC7 merged 1 commit into
mainfrom
feat/done-notification

Conversation

@TomCC7

@TomCC7 TomCC7 commented Feb 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • add notification_display_duration_ms to settings with validation and a longer default (3000ms), plus General settings UI controls
  • pass notification duration through the status poller and completion notification path so all completion-trigger branches use the same send behavior
  • update tmux notification command args to use display-message -d <ms> for both session-target and client-target sends, with coverage in arg-builder tests

Verification

  • cargo fmt
  • cargo test
  • cargo build

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.30303% with 138 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/tmux/mod.rs 33.02% 73 Missing ⚠️
src/app/polling.rs 7.69% 24 Missing ⚠️
src/ui.rs 0.00% 22 Missing ⚠️
src/app/update.rs 18.75% 13 Missing ⚠️
src/app/core.rs 54.54% 5 Missing ⚠️
src/app/mod.rs 50.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@TomCC7 TomCC7 merged commit e6fa167 into main Feb 26, 2026
3 checks passed
@TomCC7 TomCC7 deleted the feat/done-notification branch February 26, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants