fix(a11y): raise dark-theme --faint contrast to WCAG AA (4.5:1) - #496
Closed
Carlys17 wants to merge 2 commits into
Closed
fix(a11y): raise dark-theme --faint contrast to WCAG AA (4.5:1)#496Carlys17 wants to merge 2 commits into
Carlys17 wants to merge 2 commits into
Conversation
CSS var --faint in dark theme (#4e4e60) had only 2.41 contrast ratio against #0b0b12 background, failing WCAG 2 AA color-contrast checks on / and /developers. Raised --faint to #7e7e92 which achieves: - 4.94:1 on #0b0b12 - 4.80:1 on #0f0f18 - 4.82:1 on #0e0e1a - 4.67:1 on #12121f Light theme unchanged (was already 4.74+)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix WCAG 2 AA color-contrast failure on
/and/developerspages.Root cause: CSS variable
--faintin dark theme was#4e4e60, yielding only 2.41 contrast ratio against#0b0b12background (required: 4.5:1).Fix: Raised
--faintto#7e7e92achieving:#0b0b12#0f0f18#12121fLight theme unchanged (was already 4.54+).
Tested:
pnpm test:e2e→ 10/10 passed (axe-core WCAG 2.1 AA checks).Closes #413 (offline-capable holder page, PR #492).