feat(sdk): surface typed contract error taxonomy end-to-end (#404) - #466
Open
Anadudev wants to merge 2 commits into
Open
feat(sdk): surface typed contract error taxonomy end-to-end (#404)#466Anadudev wants to merge 2 commits into
Anadudev wants to merge 2 commits into
Conversation
|
@Anadudev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #404
Summary of Changes
ContractErrorClass: ConvertedContractErrorinto a typed,instanceof-checkableErrorclass carryingcode: number | null,friendly: string, andraw: string.ContractError, the canonicalPROOF_REGISTRY_ERRORScode-to-message lookup table, andisRetryableContractErrordirectly from@stellarcred/sdkand attached them to theStellarCrednamespace export.sendAndConfirmandsubmitProofsinfrontend/lib/contracts.tsto directly parse and throwContractErrorinstances upon contract execution/simulation failure rather than plain genericErrorinstances.frontend/app/holder/page.tsxproof submission catch handlers to branch one instanceof ContractErrorand useisRetryableContractError(error)to determine whether retry actions are shown or if a terminal failure state should be displayed.frontend/lib/__tests__/contracts.test.tsandfrontend/packages/sdk/src/index.test.tsverifying typed error mapping,instanceofcompatibility, namespace exports, and retryability branching.Acceptance Criteria Verified
ContractErrorinstances with error codes and friendly messages.ContractErrorand evaluates retryable vs terminal states (isRetryableContractError).PROOF_REGISTRY_ERRORSserves as the single source of truth across the stack.