Ci/frontend lint before typecheck - #463
Open
EmmyKay0026 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
pnpm lintas a required step in the frontend CI job so lint errors block merges. The job continues to run the existing typecheck, Vitest tests, additional frontend tests, and production build.Closes #215
Type of change
Merge requirements
cargo test(contracts),pnpm tsc --noEmit(frontend),pnpm build(frontend), circuit tests — all greenfixtures/<type>/artifacts updated — N/A, no circuit changesNEXT_PUBLIC_prefix on server-only env vars — N/A, no environment variable changesprehash:falsepreserved on any issuer signing path touched — N/A, no signing-path changes✅ Merge requirements
Notes for reviewers
This is a CI-only change. The frontend job now runs
pnpm lintbefore typechecking. The existingpnpm test, additional theme and issuer tests, andpnpm buildsteps remain required and fail the job normally if unsuccessful.