refactor: Add nullable annotations to struct members. #2914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
iphydf
force-pushed
the
struct-nulls
branch
3 times, most recently
from
b654efa to
c023b7b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2914 +/- ##
==========================================
+ Coverage 72.07% 72.13% +0.05%
==========================================
Files 154 154
Lines 31272 31396 +124
==========================================
+ Hits 22540 22646 +106
- Misses 8732 8750 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Green-Sky
reviewed
Jul 14, 2025
iphydf
force-pushed
the
struct-nulls
branch
3 times, most recently
from
ddd160d to
4265c7c
Compare
Green-Sky
reviewed
Jul 14, 2025
iphydf
force-pushed
the
struct-nulls
branch
2 times, most recently
from
5c420c0 to
499f9ae
Compare
Also add a bunch of casts where needed. I've tried to model everything in such a way that it minimises casts. The casts *should* be safe, but it's not always obvious. In the obvious cases, we should have a linter that validates it. In the non-obvious cases, that linter should warn and require that we add a null check. I've added some null checks in some cases but not all. Also, refactored some of the constructor functions to never assign a maybe-null value to a non-null struct member, instead using a temporary local variable to check if construction/allocation succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a bunch of casts where needed. I've tried to model everything in such a way that it minimises casts. The casts should be safe, but it's not always obvious. In the obvious cases, we should have a linter that validates it. In the non-obvious cases, that linter should warn and require that we add a null check. I've added some null checks in some cases but not all.
Also, refactored some of the constructor functions to never assign a maybe-null value to a non-null struct member, instead using a temporary local variable to check if construction/allocation succeeded.
This change is