chore: serialize engine integration tests #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakmanrq
force-pushed
the
eakmanrq/serialize_engine_integration_tests
branch
3 times, most recently
from
98ed9a8 to
9d3578c
Compare
eakmanrq
force-pushed
the
eakmanrq/serialize_engine_integration_tests
branch
from
9d3578c to
89d0e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-xdist will now start evenly distributing the tests across the N workers but make sure that tests with a common
xdist_groupend up on the same worker and therefore run sequentially. The only tests with this grouping applied are these integration tests.Only negative with this change is we lose the "worksteal" functionality where idle workers are greedy and steal work from other workers. This is a minor negative though.
Edit: impact of not having "worksteal" is bigger then I thought. It appears "worksteal" still tried to group modules together but did not provide guarantees of this. Therefore some module functions couldn't be parallelized but we never saw this because worksteal would group them together and therefore run them sequentially. Added grouping for those and we might heave some flaky tests for a bit until we get everything grouped together correctly. pytest-dev/pytest-xdist#890