Formatted code with clang-format #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I've found that can improve productivity and readability of code is formatting it. It makes it easier for multiple developers to work on the same codebase as the formatter will ensure they will all use the same style. It also make the code more readable by making the style consistent everywhere.
This is just a suggestion for the style, if you want to change it let me know and I can re-format and push. I tried to keep the style similar to what you already were using, just more consistent. Available style options are here: https://clang.llvm.org/docs/ClangFormatStyleOptions.html.
clang-formatcan be setup to run automatically when saving files in Visual Studio or in VSCode, removing the need to run it manually.