-
Notifications
You must be signed in to change notification settings - Fork 0
Code Review PR #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ToKyun02
wants to merge
5
commits into
code/review
Choose a base branch
from
main
base: code/review
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code Review PR #14
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <div align="center"> | ||
| <img src="https://capsule-render.vercel.app/api?type=waving&color=F1EFFD&height=200§ion=header&text=LocalCommu&fontSize=80&fontColor=0f0f0f&animation=fadeIn"/> | ||
| </div> | ||
|
|
||
| ## 🖐️ 프로젝트 소개 | ||
|
|
||
| > 혼자 해보는 커뮤니티 웹을 만들고 싶었고, 그렇게 탄생한 것이 LocalCommu입니다! | ||
|
|
||
| ### 🔒 로그인 | ||
| - 기본적인 로그인 및 회원가입도 지원합니다. | ||
| - 소셜 로그인(구글, 깃허브, 카카오)도 지원합니다. | ||
| - 로그인 상태에 따른 리디렉션도 middleware로 구현했습니다. | ||
|
|
||
|
|
||
| ## 🔧 프로젝트 구조 | ||
|
|
||
| ### 📝 페이지 | ||
| - / : 랜딩 페이지 => 아직 미구현입니다. | ||
| - /map : 지도 API 학습 목적으로 만든 키워드에 따른 마커 생성, 지도 이동 | ||
| - /post : 게시글 페이지 => 게시글 생성 및 조회 기능까지 완료했습니다. | ||
| - /login : 로그인 페이지 | ||
| - /signup : 회원가입 페이지 | ||
| - /auth/error : 인증 오류 관련 페이지 | ||
| - 그 외에 페이지는 현재 개발 진행 중입니다. | ||
|
|
||
| ### 🖥️ 데이터 접근 객체(DAO) | ||
| - 데이터 접근 함수를 분리시키기 위해 Dao 객체로 관리합니다. | ||
| - Dao 객체의 네이밍은 도메인별로 지었습니다. | ||
| - 정적 메소드로 구현하였기에 객체를 생성하지 않고 호출할 수 있습니다. | ||
|
|
||
| ### ♻️ 데이터 전송 객체 (DTO) | ||
| - DAO를 통해 DB에 데이터를 요청할 때 해당 DTO 모델을 작성할 것입니다. | ||
| - 일부는 DAO로 해놨지만, 향후 개선하여 이 프로젝트에선 DTO를 통해서 DAO를 이용하는 것이 목표입니다. | ||
|
|
||
| ### 💎 주요 기술 스택 | ||
|
|
||
| - Next.js(v15), React(v19), App Router | ||
| - Next-Auth V5 | ||
| - Prisma (NeonDB로 이용합니다.) | ||
| - Tanstack Query | ||
| - TypeScript | ||
| - Style : Tailwind CSS | ||
| - UI Lib : Shadcn | ||
|
|
||
|
|
||
| <div align="center"> | ||
| <img src="https://capsule-render.vercel.app/api?type=waving&color=F1EFFD&height=200§ion=footer&fontSize=80" /> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,26 @@ import type { NextConfig } from 'next'; | |
|
|
||
| const nextConfig: NextConfig = { | ||
| /* config options here */ | ||
| images: { | ||
| remotePatterns: [ | ||
| { | ||
| protocol: 'http', | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kakaocdn 은 http 로 들어오나보네요...?ㄸ
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. imageUrl 응답 확인해보니 프로토콜이 http이더라고욤.. |
||
| hostname: 'k.kakaocdn.net', | ||
| }, | ||
| { | ||
| protocol: 'https', | ||
| hostname: 'avatars.githubusercontent.com', | ||
| }, | ||
| { | ||
| protocol: 'https', | ||
| hostname: 'lh3.googleusercontent.com', | ||
| }, | ||
| { | ||
| protocol: 'https', | ||
| hostname: 'pstatic.net', | ||
| }, | ||
| ], | ||
| }, | ||
| }; | ||
|
|
||
| export default nextConfig; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일반적으로 많이 사용하는거 잘 고르셨네여ㅎㅎ
특히 Shadcn 은 저도 안써보긴 했는데 요즘 엄청 뜨고있더라구요