Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] fix vars for role names #177

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[BUGFIX] fix vars for role names #177

merged 2 commits into from
Dec 18, 2024

Conversation

teej
Copy link
Collaborator

@teej teej commented Dec 18, 2024

No description provided.

@teej teej temporarily deployed to snowflake-gcp-standard December 18, 2024 05:13 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-standard December 18, 2024 05:13 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-enterprise December 18, 2024 05:13 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-business-critical December 18, 2024 05:13 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-azure-standard December 18, 2024 05:13 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
titan/resources/resource.py 96.15% 1 Missing ⚠️
titan/role_ref.py 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/test_blueprint.py 100.00% <100.00%> (ø)
tests/test_vars.py 100.00% <100.00%> (ø)
titan/blueprint.py 88.91% <100.00%> (+0.08%) ⬆️
titan/resources/grant.py 91.73% <ø> (-0.07%) ⬇️
titan/resources/resource.py 84.96% <96.15%> (+0.23%) ⬆️
titan/role_ref.py 80.00% <75.00%> (+5.00%) ⬆️

... and 1 file with indirect coverage changes

@teej teej merged commit dc61f7f into main Dec 18, 2024
9 checks passed
@teej teej deleted the bugfix/vars branch December 18, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teej