Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] scanner package resource #139

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[FEATURE] scanner package resource #139

merged 2 commits into from
Oct 30, 2024

Conversation

teej
Copy link
Collaborator

@teej teej commented Oct 30, 2024

No description provided.

@teej teej had a problem deploying to snowflake-gcp-standard October 30, 2024 06:48 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-standard October 30, 2024 06:48 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-enterprise October 30, 2024 06:48 — with GitHub Actions Failure
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 52.77778% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
titan/data_provider.py 12.50% 14 Missing ⚠️
titan/lifecycle.py 28.57% 10 Missing ⚠️
...ts/integration/data_provider/test_list_resource.py 33.33% 4 Missing ⚠️
titan/blueprint.py 33.33% 4 Missing ⚠️
tests/integration/test_lifecycle.py 50.00% 1 Missing ⚠️
titan/resources/scanner_package.py 95.65% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/test_identities.py 96.87% <100.00%> (+0.06%) ⬆️
titan/enums.py 98.00% <100.00%> (-0.67%) ⬇️
titan/resources/__init__.py 100.00% <100.00%> (ø)
titan/resources/resource.py 83.92% <100.00%> (-0.89%) ⬇️
tests/integration/test_lifecycle.py 26.66% <50.00%> (-69.95%) ⬇️
titan/resources/scanner_package.py 95.65% <95.65%> (ø)
...ts/integration/data_provider/test_list_resource.py 34.42% <33.33%> (-55.58%) ⬇️
titan/blueprint.py 73.08% <33.33%> (-15.86%) ⬇️
titan/lifecycle.py 59.25% <28.57%> (-19.94%) ⬇️
titan/data_provider.py 12.48% <12.50%> (-70.10%) ⬇️

... and 32 files with indirect coverage changes

@teej teej had a problem deploying to snowflake-gcp-standard October 30, 2024 16:45 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-standard October 30, 2024 16:45 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-enterprise October 30, 2024 16:45 — with GitHub Actions Failure
@teej
Copy link
Collaborator Author

teej commented Oct 30, 2024

Tests are colliding for the globally scoped resources with pre-defined names. Tests pass locally.

@teej teej merged commit 59ee51f into main Oct 30, 2024
3 of 6 checks passed
@teej teej deleted the feature/trust-center branch October 30, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant