Fix issue with CLASS identifiers and unknown resources (#15)

Co-authored-by: TJ Murphy <[email protected]>

README.md

@@ -144,7 +144,7 @@ bp.apply(session, plan)
 |-----------------------------------------|----------------|----------------|----------------|
 | Plan and Execute Changes                | ✅              | ✅              | ❌              |
 | Declarative Configuration               | ✅              | ✅              | ❌              |
-| Python-Based Definitions                | ✅              | ❌              | ❌              |
+| Python-Based Definitions                | ✅              | w/ CDKTF       | ❌              |
 | SQL Support                             | ✅              | ❌              | ✅              |
 | Multi-Role Support                      | ✅              | ❌              | N/A            |
 | No State File Dependency                | ✅              | ❌              | ✅              |

scripts/install

@@ -3,7 +3,7 @@ RETURNS OBJECT NOT NULL
 LANGUAGE PYTHON
 RUNTIME_VERSION = '3.9'
 PACKAGES = ('snowflake-snowpark-python', 'inflection', 'pyparsing')
-IMPORTS = ('@titan_aws/releases/titan-0.1.2.zip')
+IMPORTS = ('@titan_aws/releases/titan-0.1.3.zip')
 HANDLER = 'titan.spi.install'
 EXECUTE AS CALLER
 CALL install()

setup.py

@@ -2,7 +2,7 @@
 
 setup(
     name="titan",
-    version="0.1.2",
+    version="0.1.3",
     description="Snowflake infrastructure as code",
     long_description=open("README.md").read(),
     long_description_content_type="text/markdown",

tests/test_parse.py

@@ -16,6 +16,7 @@
     ('"db".schema."tbl"', ['"db"', "schema", '"tbl"']),
     ('"db"."schema".tbl', ['"db"', '"schema"', "tbl"]),
     ('db."this.is:schema".tbl', ["db", '"this.is:schema"', "tbl"]),
+    ("TITAN_CLASS_TEST.PUBLIC.BASIC_MODEL.USER", ["TITAN_CLASS_TEST", "PUBLIC", "BASIC_MODEL", "USER"]),
 ]
 
 

titan/__init__.py

@@ -21,7 +21,7 @@
     "Warehouse",
 ]
 
-__version__ = "0.1.2"
+__version__ = "0.1.3"
 
 LOGO = r"""
     __  _ __          

titan/data_provider.py

@@ -438,7 +438,11 @@ def fetch_role_grants(session, role: str):
     priv_map = defaultdict(list)
 
     for row in show_result:
-        urn = _urn_from_grant(row, session_ctx)
+        try:
+            urn = _urn_from_grant(row, session_ctx)
+        except ValueError:
+            # Grant for a Snowflake resource type that Titan doesn't support yet
+            continue
         priv_map[str(urn)].append(
             {
                 "priv": row["privilege"],

titan/parse.py

@@ -14,7 +14,8 @@
 
 Identifier = pp.Word(pp.alphanums + "_", pp.alphanums + "_$") | pp.dbl_quoted_string
 FullyQualifiedIdentifier = (
-    pp.delimited_list(Identifier, delim=".", min=3, max=3)
+    pp.delimited_list(Identifier, delim=".", min=4, max=4)
+    ^ pp.delimited_list(Identifier, delim=".", min=3, max=3)
     ^ pp.delimited_list(Identifier, delim=".", min=2, max=2)
     ^ Identifier
 )
@@ -627,6 +628,15 @@ def parse_identifier(identifier: str, is_db_scoped=False) -> FQN:
             params=params,
             arg_types=arg_types,
         )
+    elif len(name_parts) == 4:
+        params["entity"] = name_parts[3]
+        return FQN(
+            database=name_parts[0],
+            schema=name_parts[1],
+            name=name_parts[2],
+            params=params,
+            arg_types=arg_types,
+        )
     raise Exception(f"Failed to parse identifier: {identifier}")