🐛 Fix MapDe dist_filter Shape
#914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiaqi-Lv
changed the title
MapDe dist_filter shape
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #914 +/- ##
===========================================
- Coverage 99.90% 99.88% -0.03%
===========================================
Files 70 70
Lines 8735 8736 +1
Branches 1149 1149
===========================================
- Hits 8727 8726 -1
- Misses 3 5 +2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
shaneahmed
changed the title
MapDe dist_filter shape MapDe dist_filter shape
shaneahmed
changed the title
MapDe dist_filter shape MapDe dist_filter Shape
|
Not sure why codecov failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dist_filterinMapDemodel for multi-class output.Explanation:
Previously, if we set
num_classto more than 1, the model would still output 1 channel. This was because thedist_filteralways had size of 1 in its first dimension, however the first dimension determines the number of output channels in the tensor produced bytorch.functional.F.conv2d.I changed this by simply repeating the filters the match the number of output classes.