new: Layout widget#84
Open
brewbytes-dev wants to merge 2 commits intoTishka17:developfrom
Open
Conversation
btrx-atikhonov
suggested changes
Sep 15, 2021
btrx-atikhonov
left a comment
btrx-atikhonov
left a comment
There was a problem hiding this comment.
- Add option to repeat sizes if there are more rows
- Documentations please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout widget added
Returns rows with predefined number of buttons.
Layout with layout=(1, 2, 3) returns the same as:
'layout' value should be defined in getter, feel free to suggest a better name
Copied get_identity, ItemsGetter in compliancy with select, list modules (both has own objects)
I also suggest thinking about merging Layout and Group in one object.