Skip to content

fix: NumberedPager._render_keyboard #465

Merged
Tishka17 merged 8 commits intoTishka17:developfrom
MarsMinerstone:develop
May 29, 2025
Merged

fix: NumberedPager._render_keyboard #465
Tishka17 merged 8 commits intoTishka17:developfrom
MarsMinerstone:develop

Conversation

@MarsMinerstone
Copy link
Copy Markdown
Contributor

The number of buttons was limited by the telegram limit and only 8 were displayed. Added a transfer to the next list to create several rows with buttons

Before:
Screenshot from 2025-03-06 12-53-32
After:
Screenshot from 2025-03-06 12-53-13

@MarsMinerstone MarsMinerstone changed the title NumberedPager._render_keyboard fix: NumberedPager._render_keyboard Mar 6, 2025
@Tishka17
Copy link
Copy Markdown
Owner

Tishka17 commented Mar 6, 2025

This can be easily achieved wrapping pager with Group()

Anyway, probably it is a good default behavior

@Tishka17 Tishka17 added the widget New widget request, or some widget fixes label Mar 6, 2025
@MarsMinerstone
Copy link
Copy Markdown
Contributor Author

MarsMinerstone commented Mar 14, 2025

can not figure out how to to make it using Group:

def verses_window() -> Window:
    LeaveComment = leave_comment(message_from=MessageFromEnum.Bible_Verses_window)
    return Window(
        MediaScroll(
            media=DynamicMedia("item"), items="photos", id="m_photo", when="photos"
        ),
        NumberedPager(scroll="m_photo"),
        state=MainSG.BibleVerses,
        getter=photos_getter,
    )

@Tishka17
Copy link
Copy Markdown
Owner

Window(
    MediaScroll(
        media=DynamicMedia("item"), items="photos", id="m_photo", when="photos"
    ),
    Group(
         NumberedPager(scroll="m_photo"),
         width=6,
    ),
    state=MainSG.BibleVerses,
    getter=photos_getter,
)

Comment thread .gitignore Outdated
Comment thread src/aiogram_dialog/widgets/kbd/pager.py Outdated
Comment thread src/aiogram_dialog/widgets/kbd/pager.py Outdated
@Tishka17 Tishka17 merged commit 5f75a28 into Tishka17:develop May 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

widget New widget request, or some widget fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants