drop support python 3.8, drop flake 8, add ruff #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirizxc
changed the title
Tishka17
reviewed
Nov 6, 2024
| if not checked and len(data) > self.min_selected: | ||
| data.remove(item_id_str) | ||
| changed = True | ||
| elif checked and self.max_selected == 0 or self.max_selected > len(data): # noqa: E501 |
There was a problem hiding this comment.
please,
- never use E501
- do not mix and+or without brackets, it is hard to read
- do not try to avoid nested conditions, sometimes it is easier to read
Tishka17
reviewed
Nov 6, 2024
| "TD", | ||
| "EM101", | ||
| "EM102", | ||
| "PT001", |
There was a problem hiding this comment.
let's enable
PT001, PT023, PLW2901, B904, RUF012, N804, B008, RUF009
and sort by name
Tishka17
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.