Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preinstalled pkg-config Homebrew recipe. #5383

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

teo-tsirpanis
Copy link
Member

@teo-tsirpanis teo-tsirpanis commented Nov 21, 2024

SC-59678

GitHub Actions now bundles pkg-config in macOS images. This PR stops installing it with brew, which causes conflicts related to the recipe's deprecation and replacement with pkgconf.


TYPE: NO_HISTORY

@teo-tsirpanis teo-tsirpanis changed the title Replace pkg-config Homebrew recipe with pkgconf. Use preinstalled pkg-config Homebrew recipe. Nov 21, 2024
@dudoslav
Copy link
Collaborator

sc-59678

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review November 22, 2024 14:16
Copy link
Collaborator

@dudoslav dudoslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all tests passed even for macos.

@teo-tsirpanis teo-tsirpanis merged commit 9f0acfa into dev Nov 26, 2024
63 checks passed
@teo-tsirpanis teo-tsirpanis deleted the teo/brew-pkgconf branch November 26, 2024 10:31
ihnorton pushed a commit to ihnorton/TileDB that referenced this pull request Dec 4, 2024
[SC-59678](https://app.shortcut.com/tiledb-inc/story/59678/core-arrays-fix-ci-on-dev-branch)

GitHub Actions now
[bundles](actions/runner-images#10971)
`pkg-config` in macOS images. This PR stops installing it with `brew`,
which causes conflicts related to the recipe's deprecation and
replacement with `pkgconf`.

---
TYPE: NO_HISTORY
ihnorton pushed a commit to ihnorton/TileDB that referenced this pull request Dec 4, 2024
[SC-59678](https://app.shortcut.com/tiledb-inc/story/59678/core-arrays-fix-ci-on-dev-branch)

GitHub Actions now
[bundles](actions/runner-images#10971)
`pkg-config` in macOS images. This PR stops installing it with `brew`,
which causes conflicts related to the recipe's deprecation and
replacement with `pkgconf`.

---
TYPE: NO_HISTORY

(cherry picked from commit 9f0acfa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants